Add Nordeck's Synapse Guest Module #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ebe7 git-subtree-dir: modules/restricted-guests/synapse git-subtree-split: 0cfebe7ba5a7368d31bf1f290bd72ff7aed513eb
…estricted-guests/synapse'
This fixes a false-positive "missing file" check in knip
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
t3chguy
reviewed
Feb 5, 2025
t3chguy
reviewed
Feb 5, 2025
modules/restricted-guests/synapse/synapse_guest_module/__init__.py
Outdated
Show resolved
Hide resolved
t3chguy
requested changes
Feb 5, 2025
Checkout from @nordeck/[email protected]
Also remove jobs for E2E & changeset, which aren't set up in this repo
|
Note that upstream doesn't have SonarCloud codecov checks, so naturally the coverage on the Synapse module will fail. Should we add something for this, or would it make more sense to do what Synapse does and use |
t3chguy
requested changes
Feb 6, 2025
There was a problem hiding this comment.
Should we add something for this, or would it make more sense to do what Synapse does and use coverage?
Given tests are here, it'd be great to wire them up to Sonar coverage. I don't think we need to hit any specific bar but it'd be good to have insight as to what level of coverage exists
The work done by the script is simpler to achieve in Bash, and avoids a potential mis-parsing of arguments.
as opposed to picking up from where upstream left off at 2.0.0. (Note that CHANGELOG.md was already at 1.0.0.)
Set license to multi-license of AGPL + Element Commercial, and add associated license files to the repository root. This does not add a notice of "This file includes modifications" to any files because they were only moved and relicensed, but otherwise unmodified. The exception is run_in_venv.sh, which is a rewrite of upstream's run_in_venv.js and thus lacks the original copyright entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Imports https://github.com/nordeck/element-web-modules/tree/main/packages/synapse-guest-module
The initial import was done with
git subtree: